Fix details-for-tree-entry.js to access fields instead of calling a function - #1326
Merged
Conversation
In details-for-tree-entry.js, there are several calls to functions of an IndexEntry. However, those are actually fields on an object instead of prototype functions so referring to them as functions will cause a ReferenceError to be thrown. The fix is to not refer to them as functions but to simply refer to them as fields instead. Signed-off-by: Remy Suen <remy.suen@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The example currently calls functions on the
IndexEntryobject but those are actually fields so they should be accessed as such.