Fix bug #39 PWD on windows gives bad path - #41
Conversation
|
Thanks @fabiengb. These changes look good to me, but they have broken some tests. We need to determine if the tests are wrong or if this is actually a breaking change. |
|
This appears to break path resolution. There are test cases where a path should resolve relative to |
|
Hi, I have implemented actual virtual root for users, preventing them to go upper from the directory they are allowed to. Plus, i have changed pathEscape function so the path showed to the client is an abstract FTP path and not the or a part of the actual FS path. |
|
@sstur will this be merged? Thanks |
|
There are some problems with this code. Apart from the stylistic issues (why are there added spaces to the end of lines all over?) I don't think the code will work in a robust way (although we will need some tests to verify this). |
|
Regarding the style issues, I will add eslint to this project and have it run as part of the tests so we don't have to discuss this on future PRs. |
|
Can this be applied ? |
|
I'm confused. I see travis claim success, but the diff view still shows several occurrences of whitespace at end of line. |
Hi,
This is the pull request you requested to fix bug #39, bad path for Windows host.
I have tested this under Windows 7 & RedHat, it seems to work OK.
Fab