Skip to content

Fix and test MDTM command #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asylumfunk merged 12 commits into from
Mar 7, 2014
Merged

Fix and test MDTM command #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
322cf37
Confine MDTM request to files in CHROOT jail
asylumfunk Mar 7, 2014
24fdbfd
Surround all blocks with curly braces
asylumfunk Mar 7, 2014
3122263
Remove superfluous empty string
asylumfunk Mar 7, 2014
29479fe
Remove superfluous newline
asylumfunk Mar 7, 2014
b0bd8fb
Return "this" instead of "undefined"
asylumfunk Mar 7, 2014
cffdc62
Remove superfluous response
asylumfunk Mar 7, 2014
f0ec043
Use a meaningful parameter name
asylumfunk Mar 7, 2014
1fb8f04
Remove "self" variable
asylumfunk Mar 7, 2014
928fb66
Add jsdoc for MDTM command
asylumfunk Mar 7, 2014
39828ab
Add test coverage for MDTM
asylumfunk Mar 7, 2014
9b9771a
Remove superfluous newlines
asylumfunk Mar 7, 2014
65ca58e
Bump version to 0.2.7
asylumfunk Mar 7, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 15 additions & 15 deletions lib/ftpd.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -543,22 +543,22 @@ FtpConnection.prototype._command_FEAT = function(commandArg) {
);
};

FtpConnection.prototype._command_MDTM = function (commandArg) {
var self = this;

var file = withCwd(self.cwd, commandArg);

self.fs.stat(file, function (err, stats) {
/**
* Print the file modification time
* @param {string} file
* @return {FtpConnection} this
*/
FtpConnection.prototype._command_MDTM = function (file) {
file = withCwd(this.cwd, file);
file = pathModule.join(this.root, file);
this.fs.stat(file, function (err, stats) {
if (err) {
if (err.code == 'ENOENT')
self.respond("550 Not found");
else
self.respond("550 Error attempting to determine modification time");
return;
}

self.respond("213 " + dateformat(stats.mtime, "yyyymmddhhMMss") + "");
});
this.respond("550 File unavailable");
} else {
this.respond("213 " + dateformat(stats.mtime, "yyyymmddhhMMss"));
}
}.bind(this));
return this;
};

FtpConnection.prototype._command_LIST = function(commandArg) {
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "ftpd",
"version": "0.2.6",
"version": "0.2.7",
"description": "Node FTP Server",
"main": "./lib/ftpd.js",
"scripts": {
Expand Down
33 changes: 33 additions & 0 deletions test/mdtm.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
var common = require('./common');

describe('MDTM command', function () {
'use strict';

var client;
var server;

beforeEach(function (done) {
server = common.server();
client = common.client(done);
});

it('should respond 213 for a valid file', function (done) {
client.raw('MDTM', '/data.txt', function (error, response) {
common.should.not.exist(error);
response.text.should.match(/^213 [0-9]{14}$/);
done();
});
});

it('should respond 550 for an invalid file', function (done) {
client.raw('MDTM', '/data2.txt', function (error, response) {
error.code.should.equal(550);
done();
});
});

afterEach(function () {
server.close();
});
});