Emitting RNTO command events. - #145
Open
ajguerreror wants to merge 2 commits into
Open
Conversation
mk-pmb
reviewed
Jun 22, 2020
| self.emit('file:rnto', status, { | ||
| fileFrom: self.filefrom, | ||
| fileTo: fileto, | ||
| error: err |
Contributor
There was a problem hiding this comment.
I'd prefer an additional errorState: Boolean(err) like we have with the file:stor event, and error: (err || false) as a convenience to users to make property access (e.g. err.name, err.message) always safe.
Author
There was a problem hiding this comment.
Ok. Doing it. One extra question: Which are the most recent compatible node version for this project?
Contributor
There was a problem hiding this comment.
I've no idea but I expect it to work with all Node.js LTS versions.
mk-pmb
approved these changes
Jun 23, 2020
Contributor
|
Thanks! 👍 |
|
You're welcome. What is the merge policy? I see a bunch of old PR's not yet merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.