Wrong response when upload fails due to file write stream error - #121
Open
jkryl wants to merge 1 commit into
Open
Wrong response when upload fails due to file write stream error#121jkryl wants to merge 1 commit into
jkryl wants to merge 1 commit into
Conversation
Contributor
|
Thanks for finding and reporting this bug! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem is that if file write stream emits an error we call storeStream.end() before setting notErr to false, so finish event handler on file stream thinks there was no error and sends 226 reply, which makes the client to believe that upload was successful even though it failed.