Skip to content

[WIP] Auth-Upgrade - #1611

Merged
bourgeoa merged 24 commits into
mainfrom
auth-upgrade
Oct 15, 2021
Merged

[WIP] Auth-Upgrade#1611
bourgeoa merged 24 commits into
mainfrom
auth-upgrade

Conversation

@jaxoncreed

@jaxoncreed jaxoncreed commented Aug 18, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

This was referenced Aug 18, 2021
Closed
Merged
Merged
Merged
Merged
Closed
@michielbdejong

michielbdejong commented Aug 19, 2021

Copy link
Copy Markdown
Member

(36/36) webid-provider
(61/61) crud
Hm, seeing a number of unexpected 412 responses for WAC
That's weird because https://github.com/solid/node-solid-server/pull/1611/files#diff-c7d94b3d28aae3dbff39c828fd35c74d0d34771fd985e3de706395173730e2bcR167 wasn't changed.
Let me double-check if these tests are currently still passing in the main branch.

@michielbdejong

michielbdejong commented Aug 19, 2021

Copy link
Copy Markdown
Member

Hm yes, does look like these tests are passing in the main branch:
https://github.com/solid/node-solid-server/runs/3349251162#step:13:784
@jaxoncreed any idea what might be causing the 412 responses?

@jaxoncreed

jaxoncreed commented Aug 19, 2021

Copy link
Copy Markdown
Contributor Author

@michielbdejong Yeah, I'm looking into it.

TallTed
TallTed reviewed Aug 20, 2021
View reviewed changes
Comment thread test/resources/accounts/localhost/index.html Outdated
TallTed
TallTed reviewed Aug 20, 2021
View reviewed changes
Comment thread test/resources/accounts/single-user/index.html Outdated
@jaxoncreed jaxoncreed changed the title Auth-Upgrade [WIP] Auth-Upgrade Aug 25, 2021
TallTed
TallTed requested changes Aug 26, 2021
View reviewed changes

@TallTed TallTed left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As noted, a couple small changes to the HTML markup

@bourgeoa

bourgeoa commented Sep 6, 2021

Copy link
Copy Markdown
Member

Thanks for latest tests fixing @jaxoncreed 3 tests are still failing locally These failing test are all in API COPY
and CI is still failing but this may be only on non main branch ?

@bourgeoa
bourgeoa merged commit 830f884 into main Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TallTed TallTed TallTed requested changes
@bourgeoa bourgeoa bourgeoa approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jaxoncreed @michielbdejong @bourgeoa @TallTed