Skip to content

Update types - #199

Merged
cjbarth merged 2 commits into
node-saml:masterfrom
cjbarth:update-types
Oct 25, 2022
Merged

Update types#199
cjbarth merged 2 commits into
node-saml:masterfrom
cjbarth:update-types

Conversation

@cjbarth

@cjbarth cjbarth commented Oct 25, 2022

Copy link
Copy Markdown
Collaborator

Description

There is still one any type in the project, this is a first step to removing that any.

@cjbarth cjbarth added the chore label Oct 25, 2022
@codecov

codecov Bot commented Oct 25, 2022

Copy link
Copy Markdown

Codecov Report

Merging #199 (c12d80c) into master (cc75f48) will increase coverage by 0.01%.
The diff coverage is 71.42%.

@@            Coverage Diff             @@
##           master     #199      +/-   ##
==========================================
+ Coverage   80.75%   80.77%   +0.01%     
==========================================
  Files          11       11              
  Lines         816      822       +6     
  Branches      247      252       +5     
==========================================
+ Hits          659      664       +5     
+ Misses         71       68       -3     
- Partials       86       90       +4     
Impacted Files Coverage Δ
src/types.ts 100.00% <ø> (ø)
src/saml.ts 78.16% <46.66%> (-0.27%) ⬇️
src/xml.ts 80.00% <100.00%> (+1.42%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cjbarth
cjbarth merged commit dffab30 into node-saml:master Oct 25, 2022
@cjbarth
cjbarth deleted the update-types branch October 25, 2022 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant