feat: expose getLogoutResponseUrlAsync publicly - #194
Conversation
|
A quick look over this code from my phone seems to indicate you just copied the test and adjust them. I don't know that we need duplicate tests. I think what we really need to test is making sure that the public contract is correct. Perhaps that could be a simple as making a call to the async function and then making a call to the callback function and making sure the results are the same except the async function should have returned it in a promise. |
|
Unfortunately, it doesn't work, SAMLResponse are different, I've tried with fake timers but still different, any idea what could be wrong? |
844535f to
604eedc
Compare
|
OK, I found out it was about the unique id generator, it should be fine now. |
Codecov Report
@@ Coverage Diff @@
## master #194 +/- ##
=======================================
Coverage 80.75% 80.75%
=======================================
Files 11 11
Lines 816 816
Branches 247 247
=======================================
Hits 659 659
Misses 71 71
Partials 86 86
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Description
Expose getLogoutResponseUrlAsync publicly.
Fixes #193.
I have duplicated the tests from the callback version with the necessary changes for async, I'm not sure whether you want to factor those tests.
Checklist: