Remove insecure clockSkew recommendation - #151
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #151 +/- ##
=======================================
Coverage 80.61% 80.61%
=======================================
Files 11 11
Lines 810 810
Branches 244 244
=======================================
Hits 653 653
Misses 71 71
Partials 86 86
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
The ADFS document was very old-- it pre-dates my involvement and I am not familiar with ADFS personally. I'm fine with removing this. If someone who uses passport-saml and ADFS wants to maintain their own documentation, they can. This doesn't need to be in the core project repo. |
markstos
approved these changes
Aug 24, 2022
|
source: README.md#usage-with-active-directory-federation-services @ 3378c915 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on this discussion, it seems we are needlessly recommending an insecure configuration and such a recommendation is being copied by others. This removes the insecure recommendation.