fix: enhance name splitting to handle "Lastname, Firstname" format#62122
Open
enjeck wants to merge 1 commit into
Open
fix: enhance name splitting to handle "Lastname, Firstname" format#62122enjeck wants to merge 1 commit into
enjeck wants to merge 1 commit into
Conversation
e1b6be7 to
ec835f7
Compare
Signed-off-by: Enjeck C. <patrathewhiz@gmail.com>
ec835f7 to
5437266
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
If an ActiveDirectory provides user names in the "Lastname, Firstname" format, Nextcloud attempts to split this string internally, but it maps the values the wrong way around.
This becomes very obvious in the Contacts app, where the "First name" field is incorrectly populated with the user's last name including the comma (e.g., "Lastname,"), and the "Last name" field contains the user's actual first name
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)