Skip to content

refactor(redis): modernize redis caching and add cluster tests#62121

Draft
susnux wants to merge 3 commits into
masterfrom
chore/legacy-redis
Draft

refactor(redis): modernize redis caching and add cluster tests#62121
susnux wants to merge 3 commits into
masterfrom
chore/legacy-redis

Conversation

@susnux

@susnux susnux commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Summary

  1. Updates min. supported phpredis version to v5.3 as this is the first version compatible with PHP 8
  2. Remove legacy code for older phpredis versions (not needed anymore)
  3. Clarify documentation
  4. Remove duplicated documentations (overriding the interfaces without new types)
  5. Update stubs from upstream
  6. Adjust code to be type compliant (psalm) - casts values where needed because we do not use MULTI mode.
  7. Add CI and tests for redis + cluster mode

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@susnux susnux added 3. to review Waiting for reviews technical debt 🧱 🤔🚀 tests Related to tests ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) labels Jul 14, 2026
@susnux susnux added this to the Nextcloud 35 milestone Jul 14, 2026
susnux added 3 commits July 14, 2026 21:06
1. Update stubs from upstream
2. Adjust minimal supported extension version to something that supports
   PHP 8.2+
3. Remove code thats outdated since we bump the min. version

Sources:
PHP 8 compatibility was added with phpredis 5.3.0-rc
https://github.com/phpredis/phpredis/blob/develop/CHANGELOG.md#530rc1

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) technical debt 🧱 🤔🚀 tests Related to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant