feat(nextcloud): add CalDAV/CardDAV redirects to HTTPRoute#866
Merged
varet80 merged 1 commit intoJul 15, 2026
Merged
Conversation
somaz94
added a commit
to somaz94/somaz94
that referenced
this pull request
Jul 2, 2026
ffcf67b to
a28f6cc
Compare
Collaborator
|
@somaz94 how come this is still draft? |
Contributor
Author
|
@varet80 No more changes coming — it was in draft only while I validated the CI matrix locally and on CI. Everything's green now, so I've marked it ready for review. Thanks for the ping! |
varet80
approved these changes
Jul 14, 2026
Collaborator
|
@somaz94 can you bump patch version of helm? |
varet80
requested changes
Jul 14, 2026
varet80
left a comment
Collaborator
There was a problem hiding this comment.
Please bump helmchart version
Signed-off-by: somaz <genius5711@gmail.com>
a28f6cc to
0a4f480
Compare
Contributor
Author
|
Bumped the chart patch version to |
varet80
approved these changes
Jul 15, 2026
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
The chart's
HTTPRoutetemplate (route.yaml) always addedbackendRefsto every rule, which made it impossible to define a rule using aRequestRedirectfilter (Gateway API rejectsRequestRedirectcombined withbackendRefs). This PR:backendRefsfor rules that do not use aRequestRedirectfilter, so redirect rules can now be defined./.well-known/carddavand/.well-known/caldav->/remote.php/dav) asRequestRedirectrules, gated behindhttpRoute.wellKnown.enabled(on by default). With Gateway API these need no implementation-specific config.Benefits
CalDAV/CardDAV service discovery works out of the box for Gateway API users, matching the ingress-nginx server-snippet behaviour already documented in the README.
Possible drawbacks
httpRoute.wellKnown.enableddefaults totrue, so users who already enablehttpRouteget the two redirect rules added on upgrade. SethttpRoute.wellKnown.enabled: falseto opt out.Applicable issues
Additional information
Validated locally with
helm lintandhelm templatefor: default (redirects + catch-all),wellKnown.enabled=false, and a user-suppliedRequestRedirectrule (confirmed nobackendRefsis rendered).Checklist
Chart.yamlaccording to semver.