Fix based on Coverity and Sonar audits (part 9) - #22337
Merged
Merged
Conversation
|
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@stelfrag I have started the AI code review. It will take a few minutes to complete. |
stelfrag
marked this pull request as ready for review
May 1, 2026 07:25
stelfrag
marked this pull request as draft
May 1, 2026 07:25
Contributor
There was a problem hiding this comment.
Pull request overview
This PR continues the audit-driven hardening of the netipc subsystem (split from #22299), focusing on overflow-safe sizing and safer stale-endpoint recovery paths across POSIX and Windows transports/services.
Changes:
- Add overflow-checked helpers for computing
header + payloadmessage lengths and apply them in send/receive and service buffer sizing paths. - Harden stale socket/SHM recovery by using safer filesystem checks (
lstat,O_NOFOLLOW, inode matching) before unlinking. - Add additional overflow guards when computing SHM region offsets/sizes (POSIX + Windows) and tighten a protocol encoder overflow check for 32-bit platforms.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/libnetdata/netipc/src/transport/windows/netipc_win_shm.c |
Adds extra overflow guards for SHM region offset/size calculation. |
src/libnetdata/netipc/src/transport/windows/netipc_named_pipe.c |
Introduces and uses a safe header+payload length helper in send/receive paths. |
src/libnetdata/netipc/src/transport/posix/netipc_uds.c |
Adds safe length helper and hardens stale socket recovery to avoid unsafe unlinks. |
src/libnetdata/netipc/src/transport/posix/netipc_shm.c |
Hardens stale SHM file recovery (no-follow, inode match) and adds region sizing overflow checks. |
src/libnetdata/netipc/src/service/netipc_service_win.c |
Adds safe sizing helpers and applies them to buffer sizing, send, and SHM profile setup. |
src/libnetdata/netipc/src/service/netipc_service.c |
Same as Windows service: safe sizing helpers applied to buffer sizing, send, and SHM profile setup. |
src/libnetdata/netipc/src/protocol/netipc_protocol.c |
Limits a size_t overflow guard to 32-bit/size-constrained platforms. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
stelfrag
marked this pull request as ready for review
May 2, 2026 19:01
thiagoftsm
approved these changes
May 3, 2026
thiagoftsm
left a comment
Contributor
There was a problem hiding this comment.
Despiste duplicate code informed by Sonarqubecloud, the PR worked as expected on Alma 9. LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary