Fix based on Coverity and Sonar audits (part 5) - #22333
Merged
Merged
Conversation
Sonar c:S2612: mark_database_to_recover() created the .netdata-meta.db.recover / .delete marker with `open(..., O_WRONLY | O_CREAT | O_TRUNC | O_CLOEXEC, 444)`. The literal `444` is decimal, which is octal 0o674 (rw-rwxr--) -- group rwx + others r. Same decimal-not-octal typo as the previous api_v1_manage.c commit. The file is a marker created and immediately closed (no body written); only its existence matters at next-startup recovery detection. It does not need group or other access. Use mode 0600 -- minimum permissions needed by the owning netdata process, eliminates the c:S2612 violation.
|
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@stelfrag I have started the AI code review. It will take a few minutes to complete. |
stelfrag
marked this pull request as ready for review
May 1, 2026 07:23
stelfrag
marked this pull request as draft
May 1, 2026 07:23
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the SQLite recovery marker file creation to use secure, owner-only permissions, aligning with audit-driven hardening from the ongoing Coverity/Sonar fix series.
Changes:
- Create
.netdata-meta.db.recover/.netdata-meta.db.deletemarker files with mode0600instead of444.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
stelfrag
marked this pull request as ready for review
May 1, 2026 07:56
ilyam8
approved these changes
May 1, 2026
Merged
Ferroin
pushed a commit
that referenced
this pull request
Jul 15, 2026
sqlite: fix decimal mode literal on recovery marker file Sonar c:S2612: mark_database_to_recover() created the .netdata-meta.db.recover / .delete marker with `open(..., O_WRONLY | O_CREAT | O_TRUNC | O_CLOEXEC, 444)`. The literal `444` is decimal, which is octal 0o674 (rw-rwxr--) -- group rwx + others r. Same decimal-not-octal typo as the previous api_v1_manage.c commit. The file is a marker created and immediately closed (no body written); only its existence matters at next-startup recovery detection. It does not need group or other access. Use mode 0600 -- minimum permissions needed by the owning netdata process, eliminates the c:S2612 violation. Co-authored-by: Costa Tsaousis <costa@netdata.cloud> (cherry picked from commit ed6e8eb)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary