fix(json): validate json_object before processing in json_walk function - #22309
Merged
Conversation
|
stelfrag
marked this pull request as ready for review
April 28, 2026 19:42
stelfrag
marked this pull request as draft
April 28, 2026 19:43
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR prevents crashes in the JSON-C json_walk path by validating the input json_object before iterating and by avoiding undefined reads from an uninitialized JSON_ENTRY.
Changes:
- Return early from
json_walkwhentis NULL or not a JSON object. - Zero-initialize
JSON_ENTRYbefore use.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
stelfrag
marked this pull request as ready for review
April 29, 2026 07:17
ilyam8
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
health.silencers.jsonfile eg with[]Summary by cubic
Add input validation to
json_walk(JSON-C path) so it only processes JSON objects. This prevents a crash whenhealth.silencers.jsonis an array (e.g.,[]) or otherwise invalid.tis NULL or notjson_type_object.JSON_ENTRYto avoid undefined reads.Written for commit f4968f9. Summary will update on new commits. Review in cubic