fix(go.d/snmp): fix retries serialization and bulk walk disable - #22179
Merged
ilyam8 merged 1 commit intoApr 10, 2026
Conversation
- Remove omitempty from OptionsConfig.Retries so zero value is serialized - Skip bulk walk detection when MaxRepetitions is 0, treating it as disabled bulk walk
stelfrag
approved these changes
Apr 10, 2026
Merged
Ferroin
pushed a commit
to stelfrag/netdata
that referenced
this pull request
Apr 10, 2026
Ferroin
pushed a commit
that referenced
this pull request
Apr 10, 2026
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan
Additional Information
For users: How does this change affect me?
Summary by cubic
Fixes
go.d/snmpconfig handling: serializes retries when set to 0 and disables bulk walk whenMaxRepetitionsis 0. This respects explicit user settings and avoids unintended bulk-walk detection.omitemptyfromOptionsConfig.Retriesso 0 is serialized.MaxRepetitionsis 0, mark bulk walk as disabled and skip detection.Written for commit dbac9d1. Summary will update on new commits.