Improve check for DBENGINE max datafile size allowed - #21390
Merged
Conversation
thiagoftsm
approved these changes
Dec 3, 2025
thiagoftsm
left a comment
Contributor
There was a problem hiding this comment.
PR is working as expected, LGTM!
stelfrag
added a commit
to stelfrag/netdata
that referenced
this pull request
Dec 5, 2025
Enhance datafile size check to prevent overflow during writes (cherry picked from commit a26cabb)
Merged
Ferroin
pushed a commit
that referenced
this pull request
Dec 15, 2025
Enhance datafile size check to prevent overflow during writes (cherry picked from commit a26cabb)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Summary by cubic
Prevent datafiles from exceeding the configured max size by making the check atomic and accounting for the incoming extent size before writing. This eliminates the race where multiple writers could overfill a file.
Written for commit 02a6308. Summary will update automatically on new commits.