feat(bigtable): add BIGTABLE_ACCELERATOR_STARTUP_TIMEOUT env var and raise default to 20s - #18
Open
mutianf wants to merge 1 commit into
Open
Conversation
mutianf
force-pushed
the
accel-16-ycsb-console-script
branch
from
August 14, 2026 15:12
0e84777 to
b7e5247
Compare
mutianf
force-pushed
the
accel-17-startup-timeout-env-var
branch
from
August 14, 2026 15:13
db6ae41 to
070d1e9
Compare
…raise default to 20s Change-Id: I5033fa2de87f6b8ac829c74bc2ca7915f7a9d467
mutianf
force-pushed
the
accel-16-ycsb-console-script
branch
from
August 14, 2026 21:02
b7e5247 to
0890bb6
Compare
mutianf
force-pushed
the
accel-17-startup-timeout-env-var
branch
from
August 14, 2026 21:02
070d1e9 to
970c71a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a
BIGTABLE_ACCELERATOR_STARTUP_TIMEOUTenvironment variable to tune the accelerator daemon's startup readiness budget without a code change or rebuild, and raises the default from 10s → 20s.Why
Cold, constrained environments (e.g. Cloud Run's gVisor sandbox) spend ~10s in Go runtime init + ADC token fetch before the daemon binds its UDS. A 10s budget frequently misses that window and silently falls back to the native client. 20s covers the cold start with margin.
Details
_STARTUP_TIMEOUT_ENV_VAR = "BIGTABLE_ACCELERATOR_STARTUP_TIMEOUT"._DEFAULT_STARTUP_TIMEOUT10.0 → 20.0._resolve_startup_timeout()— precedence: explicit constructor arg > env var > default. A malformed or non-positive env value is raised loudly as a deployment misconfiguration rather than silently ignored.AcceleratorDaemon(startup_timeout=...)default changed toNoneso the env var is read at instantiation time.Scope:
_daemon.pyonly.Stacking
Stacked on top of #accel-16-ycsb-console-script. Review/merge that first.