test(bigtable): add accelerator lifecycle and leak tests - #11
Open
mutianf wants to merge 2 commits into
Open
Conversation
mutianf
force-pushed
the
accel-11-lifecycle-leak-tests
branch
from
August 11, 2026 14:07
aa06892 to
c9e1985
Compare
mutianf
force-pushed
the
accel-11-lifecycle-leak-tests
branch
from
August 12, 2026 03:04
c9e1985 to
c26b6d4
Compare
mutianf
force-pushed
the
accel-11-lifecycle-leak-tests
branch
from
August 12, 2026 14:07
c26b6d4 to
992099b
Compare
mutianf
commented
Aug 12, 2026
| ) | ||
|
|
||
| @CrossSync.pytest | ||
| async def test_no_leaks_over_repeated_lifecycles(self, instance_id, table_id): |
Owner
Author
There was a problem hiding this comment.
This only tests normal close (happy path). How about all the other failure scenarios? e.g. python SDK crashed
Owner
Author
There was a problem hiding this comment.
Added two non-happy-path leak tests (commit e024e78):
test_no_daemon_leak_when_owner_process_is_killed— the requested "Python SDK crashed" case. Spawns a child process that builds a real accelerated table (so it owns a real daemon), reports the daemon pid + tempdir, then SIGKILLs it with noclose(). Asserts the orphaned daemon self-terminates via its stdin-EOF watchdog (tracked by pid, since it reparents to init on the kill), and cleans up the leftover tempdir.test_close_reclaims_resources_after_daemon_crash— the daemon dies unexpectedly (SIGKILL) out from under the client; asserts a normalclose()still reaps it and reclaims the tempdir with no leaked subprocess/fd/dir.
Both reuse the existing _harness leak helpers (daemon_pid, pid_alive, ProcessIntrospector). Regenerated the CrossSync sync twin.
mutianf
force-pushed
the
accel-11-lifecycle-leak-tests
branch
from
August 12, 2026 16:32
e024e78 to
d89f2dc
Compare
mutianf
force-pushed
the
accel-11-lifecycle-leak-tests
branch
from
August 12, 2026 18:56
d89f2dc to
17c8bf9
Compare
mutianf
force-pushed
the
accel-11-lifecycle-leak-tests
branch
from
August 12, 2026 19:04
17c8bf9 to
840229f
Compare
Change-Id: Ib7073ae88b1716361626214367a7eee08f1d1daf
…rash teardown Change-Id: I6f3990ee58926fd6ac6e1d83999e817bd4cd15f0
mutianf
force-pushed
the
accel-11-lifecycle-leak-tests
branch
from
August 14, 2026 21:02
840229f to
0f82a63
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds accelerator lifecycle and leak tests (async + autogen).
Part of the accelerator test stack. Stacked on top of #10.