Skip to content

fix: use-after-free in unpackb() ExtraData path for non-contiguous input #722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
methane merged 2 commits into from
Aug 5, 2026
+28 −7
Merged

fix: use-after-free in unpackb() ExtraData path for non-contiguous input #722

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea4bd9d
fix: use-after-free in unpackb() ExtraData path for non-contiguous input
ThomasWaldmann Aug 3, 2026
58b6fd9
refactor
methane Aug 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
refactor
  • Loading branch information
@methane
methane committed Aug 5, 2026
commit 58b6fd9faebfed9aa327d3ccf7447487a609c7c2
17 changes: 7 additions & 10 deletions msgpack/_unpacker.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,19 +191,16 @@ def unpackb(object packed, *, object object_hook=None, object list_hook=None,
use_list, raw, timestamp, strict_map_key, cerr,
max_str_len, max_bin_len, max_array_len, max_map_len, max_ext_len)
ret = unpack_construct(&ctx, buf, buf_len, &off)
if ret == 1 and off < buf_len:
# buf may point into a temporary contiguous copy owned by view,
# so the extra data must be copied out before releasing view.
extra = PyBytes_FromStringAndSize(buf+off, buf_len-off)
if ret == 1:
obj = unpack_data(&ctx)
if off < buf_len:
# buf may point into a temporary contiguous copy owned by view,
# so the extra data must be copied out before releasing view.
raise ExtraData(obj, PyBytes_FromStringAndSize(buf+off, buf_len-off))
return obj
finally:
PyBuffer_Release(&view);

if ret == 1:
obj = unpack_data(&ctx)
if extra is not None:
raise ExtraData(obj, extra)
return obj

unpack_clear(&ctx)
if ret == 0:
raise ValueError("Unpack failed: incomplete input")
Expand Down