Skip to content

Submodule referencesource removal - #2962

Merged
marek-safar merged 314 commits into
mono:masterfrom
marek-safar:referencesource-submodule-move
May 4, 2016
Merged

Submodule referencesource removal#2962
marek-safar merged 314 commits into
mono:masterfrom
marek-safar:referencesource-submodule-move

Conversation

@marek-safar

Copy link
Copy Markdown
Member

Removes referencesource submodule and moves sources to mcs/class/referencesource

This simplified PR workflow and makes branching easier

atsushieno and others added 30 commits May 3, 2016 00:07
…rosoft namespace

This will let us have both the Mono and the Microsoft ThreadPool at the same time.
To switch to the Microsoft one, set the MONO_THREADPOOL environment variable to "microsoft". It will default to the Mono one.
Add resources for:
mscorlib
System
System.ComponentModel.DataAnnotations
System.Core
System.Core
System.Data.DataSetExtensions
System.Data.Entity.Design
System.Data.Entity
System.Data.Linq
System.Data.SqlXml
System.Data
System.Net
System.Numerics
System.Runtime.Serialization
System.ServiceModel.Web
System.ServiceModel
System.Web.Mobile
System.Web
System.Xml.Linq
System.Xml
Adding reference source for
System.Activities
System.Activities.DurableInstancing
System.Activities.Presentation
System.Runtime.DurableInstancing
System.Workflow.Activities
System.Workflow.ComponentModel
System.Workflow.Runtime
System.WorkflowServices
System.Xaml.Hosting
XamlBuildTask
…n classes."

This reverts commit b23609f81a95b384538dba01a1cbf49fe2a9b95a.

Confirmed by Brett Lopez as MSDN bug
DISABLE_CAS_USE is required to avoid NotImplementedExceptions in CAS land.

MONO_HYBRID_XML is to preserve Mono's XmlSerializer which also allows
interpreter-based XML serialization (as opposed to run-time code generation
based XML serialization, which is not doable in iOS).

Though some Xml.Serialization classes are useful even with mono
implementation, so we partially import them (namely schema importer).
Somewhere in System.Xml requires NameTable to be canonically reused when
deserializing XmlSchema, so that certain deserialization part can check
only reference equality.

Since we have hybrid System.Xml implementation for XmlSerializer, this
is not completely achieved and with reference comparison it causes some
schema deserialization failure. To avoid this problem, just disable
reference comparison. It should not affect outside XmlSchema serialization.
The former condition is to disable <msxsl:script> element.
The latter is to disable XslCompiledTransform and co (though they are
mostly removed at *.dll.sources level).
marek-safar and others added 24 commits May 3, 2016 11:42
… of which breaks build"

This reverts commit 0cb499950a7ae61c62c433c8cce353d535dbd09e.
GetHRForLastWin32Error breaks the build on AOT, and even on non-AOT is unimplemented.
NativeMethods.GetExitCodeProcess would inherently be broken on Unix platforms for non-child processes as it can't succesfully get the exit code. This would in turn break Process.HasExited, which should not break, as it is possible to check if a non-child process is alive or dead.
…e22, it was eaten up by the .NET 4.6 merge. Fixes #38712
In case the runtime would fail to wait on the wait handle(s), we would still return true, as if the WaitHandle was successfully signaled.
When FileInfo was imported in mono@bdd0de7 the check in Delete()
got removed that raised an UnauthorizedAccessException when the FileInfo object holds a path to a directory instead of a file.

It happened to pass the MonoTests.System.IO.FileInfoTest.Delete_Directory test on OSX because unlink returns EPERM there
which got turned into the expected UnauthorizedAccessException, but on Linux it returns EISDIR so the test would fail.

Fix is to put the explicit check for directory back.
…ncesource

This simplified PR workflow and makes branching easier
@marek-safar
marek-safar merged commit d70777a into mono:master May 4, 2016
@marek-safar
marek-safar deleted the referencesource-submodule-move branch May 4, 2016 06:17
akoeplinger added a commit that referenced this pull request May 23, 2016
Since referencesource is no longer a submodule under external/ after #2962
it didn't get included in the tarball anymore.

We need to add it again to fix the tarball build.
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
…bmodule-move

Submodule referencesource removal

Commit migrated from mono/mono@d70777a
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
Since referencesource is no longer a submodule under external/ after mono/mono#2962
it didn't get included in the tarball anymore.

We need to add it again to fix the tarball build.


Commit migrated from mono/mono@6890eab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.