Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

Enable to support Nokogiri >= 1.10.3 - #45

Merged
Michael Mainer (MIchaelMainer) merged 1 commit into
microsoftgraph:masterfrom
JunichiIto:update-nokogiri
Apr 23, 2019
Merged

Enable to support Nokogiri >= 1.10.3#45
Michael Mainer (MIchaelMainer) merged 1 commit into
microsoftgraph:masterfrom
JunichiIto:update-nokogiri

Conversation

@JunichiIto

@JunichiIto Junichi Ito (JunichiIto) commented Apr 23, 2019

Copy link
Copy Markdown
Contributor

For the issue #44

@msftclas

Microsoft Contribution License Agreements (msftclas) commented Apr 23, 2019 •
edited
Loading

Copy link
Copy Markdown

CLA assistant check
All CLA requirements met.

@JunichiIto Junichi Ito (JunichiIto) mentioned this pull request Apr 23, 2019
Closed
@MIchaelMainer

Michael Mainer (MIchaelMainer) commented Apr 23, 2019

Copy link
Copy Markdown
Contributor

What's the benefit of requiring "adal/request_parameters"? Don't we get that when we require adal?

@JunichiIto

Junichi Ito (JunichiIto) commented Apr 23, 2019

Copy link
Copy Markdown
Contributor Author

Michael Mainer (@MIchaelMainer) Without this, I get uninitialized constant ADAL::ClientAssertionCertificate::RequestParameters error when I run rspec.

This issue is related: AzureAD/azure-activedirectory-library-for-ruby#44

As I mentioned in the comment, it will be fixed if the following PR is released, but it has been ignored for a long time.

AzureAD/azure-activedirectory-library-for-ruby#50

@MIchaelMainer
Michael Mainer (MIchaelMainer) merged commit e5408c4 into microsoftgraph:master Apr 23, 2019
@NDuggan

Niall Duggan (NDuggan) commented Oct 2, 2019

Copy link
Copy Markdown

Junichi Ito (@JunichiIto) Hi, we've just tried to use this as well and the latest gem on Rubygems doesn't seem to be updated/have a release so I've had to link directly to the git commit ref. Could we get a new release please?

@JunichiIto

Junichi Ito (JunichiIto) commented Oct 3, 2019

Copy link
Copy Markdown
Contributor Author

Niall Duggan (@NDuggan) Sorry, I am not the maintainer of this gem.

Michael Mainer (@MIchaelMainer) This PR has been merged but it's not released. Could you release it please?

@NDuggan

Niall Duggan (NDuggan) commented Oct 3, 2019

Copy link
Copy Markdown

Junichi Ito (@JunichiIto) apologies, I misread contributor. Thanks for the push in the right direction though!

@jasonjoh Jason Johnston (jasonjoh) mentioned this pull request Feb 10, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JunichiIto @msftclas @MIchaelMainer @NDuggan