Generated v1.0 models and request builders using Typewriter - #814
Closed
github-actions[bot] wants to merge 3 commits into
Closed
Generated v1.0 models and request builders using Typewriter#814github-actions[bot] wants to merge 3 commits into
github-actions[bot] wants to merge 3 commits into
Conversation
github-actions
Bot
requested review from
Michael Mainer (MIchaelMainer),
Vincent Biret (baywet),
DeVere Dyett (ddyett),
Nikitha Chettiar (nikithauc) and
Mustafa Zengin (zengin)
as code owners
June 22, 2021 12:21
Vincent Biret (baywet)
approved these changes
Jun 22, 2021
Vincent Biret (baywet)
left a comment
Member
There was a problem hiding this comment.
Michael Mainer (@MIchaelMainer) the fact that some teams entities changed their properties types from identityset to chatmessageidentityset (which inherits from the former) is potentially a breaking change for people creating/updating information.
See this example
Vincent Biret (baywet)
requested changes
Jun 23, 2021
Vincent Biret (baywet)
left a comment
Member
There was a problem hiding this comment.
blocking for now as discussed offline
Contributor
|
Vincent Biret (@baywet) I think we should treat this as a blocking for all of the SDKs. We should close out all PRs with these changes. |
Member
|
agreed, waiting on Darrel (@darrelmiller) to confirm after he talks with the owner. |
Member
|
Closing as replaced by #815 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request was automatically created by the GitHub Action, create pull request.
The commit hash is 586ed44.
Important Check for unexpected deletions or changes in this PR.