Skip to content

Add ADMX definition for Group Policy - #809

Merged
Flor Chacón (florelis) merged 15 commits into
microsoft:masterfrom
florelis:PolicyADMX
Apr 6, 2021
Merged

Add ADMX definition for Group Policy#809
Flor Chacón (florelis) merged 15 commits into
microsoft:masterfrom
florelis:PolicyADMX

Conversation

@florelis

@florelis Flor Chacón (florelis) commented Mar 18, 2021

Copy link
Copy Markdown
Member

Adding definition file for a group policy. See #154

Still pending:

  • Setting up localization for the strings.
  • Figuring out a representation for the lists of allowed and additional sources. Currently it is only a list of name/value pairs but we can't represent all three of name, arg & type.

Code to respect the policy will come as a separate PR

Microsoft Reviewers: Open in CodeFlow

@github-actions

Copy link
Copy Markdown

Misspellings found, please review:

  • Aditional
  • adml
  • admx
  • xsi
To accept these changes, run the following commands from this repository on this branch
pushd $(git rev-parse --show-toplevel)
perl -e '
my @expect_files=qw('".github/actions/spelling/expect.txt"');
@ARGV=@expect_files;
my @stale=qw('"validator valijson valueiterator "');
my $re=join "|", @stale;
my $suffix=".".time();
my $previous="";
sub maybe_unlink { unlink($_[0]) if $_[0]; }
while (<>) {
  if ($ARGV ne $old_argv) { maybe_unlink($previous); $previous="$ARGV$suffix"; rename($ARGV, $previous); open(ARGV_OUT, ">$ARGV"); select(ARGV_OUT); $old_argv = $ARGV; }
  next if /^(?:$re)(?:(?:\r|\n)*$| .*)/; print;
}; maybe_unlink($previous);'
perl -e '
my $new_expect_file=".github/actions/spelling/expect.txt";
use File::Path qw(make_path);
make_path ".github/actions/spelling";
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"Aditional adml admx xsi "');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a) cmp lc($b)} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;'
popd

@JohnMcPMS

Copy link
Copy Markdown
Member

I think Demitrius Nelon (@denelon) needs to approve this for location and content.

We will need to investigate how to integrate this with the localization build; I can help inform you of how the current one works.

Not really part of the PR, but I think that we do need to have a process for how we release and version this as well. At a minimum, new policies will need documentation to indicate when they will be effective.

Comment thread doc/admx/WindowsAppInstaller.admx Outdated
Josh Soref (jsoref) added a commit to check-spelling-sandbox/winget-cli that referenced this pull request Mar 30, 2021
@jsoref Josh Soref (jsoref) mentioned this pull request Mar 30, 2021
@florelis
Flor Chacón (florelis) marked this pull request as ready for review April 6, 2021 21:35
@florelis
Flor Chacón (florelis) requested a review from a team as a code owner April 6, 2021 21:35
Comment thread src/AppInstallerCLI.sln Outdated
Comment thread src/AppInstallerCommonCore/GroupPolicy.cpp Outdated
@florelis

Copy link
Copy Markdown
Member Author

Using final names/strings from discussion with Demitrius Nelon (@denelon)
Here's a summary:
File names: DesktopAppInstaller.adm[x,l]
Location of the policies in gpedit: Computer Configuration\AdministrativeTemplates\Windows Components\Desktop App Installer
Location of the backing registry keys: HKLM:\Software\Policies\Microsoft\Windows\AppInstaller
Policy names use "App Installer", descriptions use "Windows Package Manager"

I set the supported OS to SUPPORTED_Windows_10_0_RS3 = version 1709.

@denelon Demitrius Nelon (denelon) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@florelis
Flor Chacón (florelis) merged commit 82f994d into microsoft:master Apr 6, 2021
@florelis
Flor Chacón (florelis) deleted the PolicyADMX branch April 6, 2021 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants