Added a note about MSStoreProductIdentifier non-support to RestInterface_1_1.cpp. - #6458
Closed
Imre Eilertsen (DandelionSprout) wants to merge 1 commit into
Closed
Added a note about MSStoreProductIdentifier non-support to RestInterface_1_1.cpp.#6458Imre Eilertsen (DandelionSprout) wants to merge 1 commit into
Imre Eilertsen (DandelionSprout) wants to merge 1 commit into
Conversation
Imre Eilertsen (DandelionSprout)
requested a review
from a team
as a code owner
August 12, 2026 07:17
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
7 tasks
Contributor
Author
|
Closing in light of microsoft/winget-pkgs#416221 indicating it is supported (sort-of) after all. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📖 Description
The following section in https://github.com/microsoft/winget-cli/blob/master/src/AppInstallerCLITests/RestInterface_1_1.cpp claims that the following would be able to get working in a manifest:
It can't.
So this PR adds a note about that it can't.
🔗 References
🔍 Validation
Added a secondary installer to a manifest that used the syntaxing used for the
msstoreInstallerType in https://github.com/microsoft/winget-cli/blob/master/src/AppInstallerCLITests/RestInterface_1_1.cpp✅ Checklist
📋 Issue Type
Microsoft Reviewers: Open in CodeFlow