DSCv3 admin settings resource - #5458
Merged
Merged
Conversation
AmirMS (AmelBawa-msft)
previously approved these changes
May 15, 2025
|
|
||
| namespace AppInstaller::CLI | ||
| { | ||
| // A resource for managing source configuration. |
Contributor
There was a problem hiding this comment.
Suggested change
| // A resource for managing source configuration. | |
| // A resource for managing admin settings. | |
yao-msft
reviewed
May 15, 2025
| throw CommandException(Resource::String::InvalidArgumentSpecifierError(ArgumentCommon::ForType(Execution::Args::Type::SettingName).Name)); | ||
| } | ||
|
|
||
| return; |
Contributor
There was a problem hiding this comment.
if (ContainsAll && ContansSettingsName)
{
throw ArgumentConflict()?
}
Member
Author
There was a problem hiding this comment.
Except that it also needs to return if not throwing.
yao-msft
reviewed
May 15, 2025
yao-msft
left a comment
Contributor
There was a problem hiding this comment.
Also add to Predefined Export list with elevation true?
| <value>Manage administrator settings</value> | ||
| </data> | ||
| <data name="DscAdminSettingsResourceLongDescription" xml:space="preserve"> | ||
| <value>Allows management of administrator settings the DSC v3 command line interface protocol. See the help link for details.</value> |
Contributor
There was a problem hiding this comment.
Suggested change
| <value>Allows management of administrator settings the DSC v3 command line interface protocol. See the help link for details.</value> | |
| <value>Allows management of administrator settings through the DSC v3 command line interface protocol. See the help link for details.</value> | |
yao-msft
approved these changes
May 15, 2025
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Adds an admin settings resource to mirror the existing v2.
Also adds
winget settings reset --allto reset all admin settings to their default values (respecting group policy of course).Validation
Added E2E tests for invoking the resource.
Microsoft Reviewers: Open in CodeFlow