Only forward the verbose property if it has been set - #5449
Merged
Conversation
AmirMS (AmelBawa-msft)
approved these changes
May 10, 2025
yao-msft
approved these changes
May 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
To prevent an error from attempting to parse a boolean from an empty string, only forward the diagnostics (verbose) property if it has been set.
Validation
Tried with and without verbose, logs are as expected. We should take time in the future to make the E2E tests exercise the dynamic factory more.
Microsoft Reviewers: Open in CodeFlow