Add support for exporting package related DSC v3 resources and some predefined resources in configure export all - #5428
Merged
Merged
Conversation
JohnMcPMS
reviewed
May 2, 2025
| <value>Applying configuration unit...</value> | ||
| </data> | ||
| <data name="ConfigurationExportingUnit" xml:space="preserve"> | ||
| <value>Applying configuration unit...</value> |
Member
There was a problem hiding this comment.
Suggested change
| <value>Applying configuration unit...</value> | |
| <value>Exporting configuration unit...</value> |
Comment on lines
+50
to
+51
| constexpr std::wstring_view s_UnitType_WinGetPackage_DSCv3 = L"Microsoft.WinGet/WinGetPackage"; | ||
| constexpr std::wstring_view s_UnitType_WinGetSource_DSCv3 = L"Microsoft.WinGet/WinGetSource"; |
Member
There was a problem hiding this comment.
Suggested change
| constexpr std::wstring_view s_UnitType_WinGetPackage_DSCv3 = L"Microsoft.WinGet/WinGetPackage"; | |
| constexpr std::wstring_view s_UnitType_WinGetSource_DSCv3 = L"Microsoft.WinGet/WinGetSource"; | |
| constexpr std::wstring_view s_UnitType_WinGetPackage_DSCv3 = L"Microsoft.WinGet/Package"; | |
| constexpr std::wstring_view s_UnitType_WinGetSource_DSCv3 = L"Microsoft.WinGet/Source"; |
Also, to prevent conflicts I'm making the dev build use `Microsoft.WinGet.Dev" as the root name. I can deal with the fallout though.
Contributor
There was a problem hiding this comment.
Do we need to add UserSettingsFile resource here?
Contributor
Author
There was a problem hiding this comment.
It's declared in below PredefinedResources
JohnMcPMS
previously approved these changes
May 2, 2025
Flor Chacón (florelis)
previously approved these changes
May 3, 2025
Flor Chacón (florelis)
left a comment
Member
There was a problem hiding this comment.
(I only looked at the last commit after John's review)
JohnMcPMS
previously approved these changes
May 3, 2025
yao-msft
dismissed stale reviews from JohnMcPMS and Flor Chacón (florelis)
via
May 3, 2025 04:35
122354e
JohnMcPMS
approved these changes
May 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Microsoft Reviewers: Open in CodeFlow