Add api to find unit processors based on search path - #5386
Merged
Conversation
JohnMcPMS
reviewed
Apr 15, 2025
JohnMcPMS
left a comment
Member
There was a problem hiding this comment.
While this code can find (and even execute) resources that are not on the configured PATH, we should not export any resource that isn't discoverable by a standard call to dsc.exe. If we do, the configuration won't work without special code to find them again on the apply-side.
| } | ||
| else | ||
| { | ||
| AICLI_LOG(Config, Warning, << "Set Processor does not support FindUnitProcessors operation"); |
Member
There was a problem hiding this comment.
I feel like this should be an error to indicate that the operation could not be performed. We already do similar with the GetAll* functions.
Member
There was a problem hiding this comment.
I meant that the API should produce an error.
| else | ||
| { | ||
| AICLI_LOG(Config, Warning, << "Set Processor does not support FindUnitProcessors operation"); | ||
| return winrt::single_threaded_vector<IConfigurationUnitProcessorDetails>(); |
Member
There was a problem hiding this comment.
Same error as ConfigurationProcessor.
JohnMcPMS
approved these changes
Apr 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added EnvironmentVariables customization support for ProcessExecution.
Added ProcessorRunSettings to customize each processor run settings. Currently only used to change path environment variables for processor runs.
Added support to find unit processors based on search path. If search paths not provided, the api will list all unit processors that can be found.
Added e2e tests.
Microsoft Reviewers: Open in CodeFlow