Skip to content

Handle not finding metadata - #5350

Merged
JohnMcPMS merged 1 commit into
microsoft:masterfrom
JohnMcPMS:find-might-not-find
Apr 11, 2025
Merged

Handle not finding metadata#5350
JohnMcPMS merged 1 commit into
microsoft:masterfrom
JohnMcPMS:find-might-not-find

Conversation

@JohnMcPMS

@JohnMcPMS JohnMcPMS commented Apr 2, 2025

Copy link
Copy Markdown
Member

Fixes #5349

Change

Return an empty hstring if we don't find a metadata key rather than attempting to dereference an invalid iterator.

Thanks luke-patchblox for pointing out the issue precisely (although you took all the fun out of diagnosing it 😝)

Microsoft Reviewers: Open in CodeFlow

@JohnMcPMS
JohnMcPMS requested a review from a team as a code owner April 2, 2025 22:29
@JohnMcPMS

Copy link
Copy Markdown
Member Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@JohnMcPMS
JohnMcPMS merged commit d526776 into microsoft:master Apr 11, 2025
@JohnMcPMS
JohnMcPMS deleted the find-might-not-find branch April 11, 2025 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

COM PackageVersionInfo null deference bug

2 participants