Update configuration environment behavior - #5182
Merged
Merged
Conversation
yao-msft
previously approved these changes
Feb 5, 2025
| /// </summary> | ||
| /// <param name="set">The set to output.</param> | ||
| /// <returns>The string.</returns> | ||
| public static string ToYaml(this ValueSet set) |
Contributor
There was a problem hiding this comment.
I saw this is only used in tests. Is it expected to be used in product code in the future? If not, shall we move the code to test common?
Member
Author
There was a problem hiding this comment.
I honestly didn't notice that this was in the processor; I just assumed that it was in the unit tests as that is how I navigated there (via F12 from a test).
|
|
||
| [contract(Microsoft.Management.Configuration.Contract, 3)] | ||
| { | ||
| // The environment in which to process the configuration set. |
Contributor
There was a problem hiding this comment.
How is the configuration contract version defined? Is it tied to the schema version? (i.e. not tied to our releases since it's still in preview only?)
Member
Author
There was a problem hiding this comment.
We don't have a strict contract number mapping to anything outside of the interface definition.
yao-msft
approved these changes
Feb 5, 2025
JohnMcPMS
added a commit
to JohnMcPMS/winget-cli
that referenced
this pull request
Feb 6, 2025
## Change In response to some other discussions, update the configuration environment behavior: 1. Add an environment at the set level 2. Don't inherit environment data into child units, and don't promote environment data when serializing Updated the one consumer of environment (dynamic factory) to be responsible for the flow of the security context from the set to the immediate child units. Also improved serialization of groups to output the non-resource properties.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
In response to some other discussions, update the configuration environment behavior:
Updated the one consumer of environment (dynamic factory) to be responsible for the flow of the security context from the set to the immediate child units.
Also improved serialization of groups to output the non-resource properties.
Microsoft Reviewers: Open in CodeFlow