Fix commit message overflow#623
Merged
miguelsolorio merged 2 commits intomicrosoft:masterfrom Oct 30, 2018
JeffreyCA:commit-msg-overflow
Merged
Fix commit message overflow#623miguelsolorio merged 2 commits intomicrosoft:masterfrom JeffreyCA:commit-msg-overflow
miguelsolorio merged 2 commits intomicrosoft:masterfrom
JeffreyCA:commit-msg-overflow
Conversation
Member
Author
|
Not sure what happened, 2 of my PRs (this and #645) are no longer in the current master branch. None of these changes can be seen in master. |
|
@JeffreyCA we're looking into it, it's quite strange that this was clearly merged above but there is no trace of it in |
Member
|
@JeffreyCA I cherry picked your commits to master and added disable-force-push rule to master, let's see if this happens again or not. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #609 and #618