Skip to content

Add progress notification to create#3737

Merged
alexr00 merged 1 commit intomainfrom
alexr00/issue3531
Jul 19, 2022
Merged

Add progress notification to create#3737
alexr00 merged 1 commit intomainfrom
alexr00/issue3531

Conversation

@alexr00
Copy link
Copy Markdown
Member

@alexr00 alexr00 commented Jul 19, 2022

Fixes #3531

@alexr00 alexr00 enabled auto-merge (squash) July 19, 2022 08:03
@github-actions github-actions bot added this to the July 2022 milestone Jul 19, 2022
@joaomoreno
Copy link
Copy Markdown
Member

@alexr00 Is a notification the best we can do here? Can't we somehow show progress in the view itself?

@alexr00
Copy link
Copy Markdown
Member Author

alexr00 commented Jul 19, 2022

@joaomoreno It's a webview, so we can do whatever we want in it, but I was trying to stay consistent with how we show progress elsewhere.

@alexr00 alexr00 merged commit f2ea88b into main Jul 19, 2022
@alexr00 alexr00 deleted the alexr00/issue3531 branch July 19, 2022 09:29
@joaomoreno
Copy link
Copy Markdown
Member

@alexr00 A good example of what I mean is @benibenj's fix in #3729: that operation was slow so we had to show progress somewhere. The fix was to show the UI prematurely and show progress there. An alternative fix would've been to use a notification for progress and open quick open once done; this would've been a bit jarring.

Maybe we need a restructuring in the view such that we can open it immediately and show progress within... but it would definitely improve the overall experience. What do you think?

@alexr00
Copy link
Copy Markdown
Member Author

alexr00 commented Jul 20, 2022

@joaomoreno I understand what you're saying now. Errors would be weird since we currently show them in the "Create" view and we'd need to re-open the create view on error (as errors can often be resolved by changing something in the create view), but it is doable. Opened #3743.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Investigate performance of "Create" view

3 participants