Implement Java Overview page - #36
Merged
Merged
Conversation
Rome Li (akaroml)
requested review from
Yan Zhang (Eskibear),
Jinbo Wang (testforstephen) and
Yaohai Zheng (yaohaizh)
September 10, 2018 13:49
| } | ||
|
|
||
| function initializeTelemetry(context: vscode.ExtensionContext) { | ||
| const packageInfo = require(context.asAbsolutePath('./package.json')); |
Contributor
There was a problem hiding this comment.
use extentions.getExtension('extensionId').packageInfo
|
|
||
| function hideInstalledExtensions(extensions: any) { | ||
| $('div[ext]').each((index, elem) => { | ||
| let anchor = $(elem); |
Contributor
There was a problem hiding this comment.
let ==> const
| }); | ||
| } | ||
|
|
||
| export async function createMavenProjectCmdHanlder(context: vscode.ExtensionContext) { |
Contributor
There was a problem hiding this comment.
See some duplicate. Use some key value pairs to reduce the function number?
Yan Zhang (Eskibear)
requested changes
Sep 10, 2018
Yan Zhang (Eskibear)
left a comment
Member
There was a problem hiding this comment.
Some telemetry related questions.
| const packageInfo = require(context.asAbsolutePath('./package.json')); | ||
| if (packageInfo) { | ||
| if (packageInfo.aiKey) { | ||
| initialize(packageInfo.name, packageInfo.version, packageInfo.aiKey, true); |
Member
There was a problem hiding this comment.
Remove "true" please.
Member
There was a problem hiding this comment.
For the first parameter, a) packageInfo.name v.s. b) ${packageInfo.publisher}.${packageInfo.name}?
a) concise and shorter.
b) strictly unique.
It looks you prefer a). Shall we be consistent for all the extensions?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the second PR to address #32