Fix: Target path is wrong when exporting jar from a workspace node - #384
Merged
Conversation
Sheng Chen (jdneo)
requested changes
Nov 17, 2020
1. Move `createJarFile` to `ExportJarTaskProvider` 2. Keep the undefined check in `ResolveJavaProjectExecutor` 3. Use `finishExportJarTask()` to report task status
| export async function finishExportJarTask(restart: boolean, node?: INodeData): Promise<void> { | ||
| isExportingJar = false; | ||
| if (restart) { | ||
| executeExportJarTask(node); |
Contributor
Author
There was a problem hiding this comment.
Currently, the node here is always undefined because only the export jar process triggered by the button in the title of the Project Manager (not by the inline button of workspaceNode) could go back to the ResolveJavaProject step.
Should the node be undefined or just keep it for the consistency here?
Member
There was a problem hiding this comment.
This function is a trouble. Some reasons:
- Still, it makes the people have to read the code between
exportJarFileCommand.ts&ExportJarTaskProvider.tsback and forth - It's named
finishExportJarTaskbut with a paramrestart, confusing here.
1. Remove exportJarFileCommand.ts. The `ExportJarStep` and `stepMap` are moved to `utility.ts` and the functions are moved to `ExportJarTaskProvider.ts` as a new class called ExportJarCommand
Sheng Chen (jdneo)
approved these changes
Nov 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #382