Integrate the ExP framework - #260

You should actually use version 0.0.659 of vscode-tas-client for now. 0.0.702 has a bug that I'll resolve later this week.

The vscode-tas-client package will query the treatment assignment service in the background (every 30 minutes), so flight information should never be much staler than the last opened instance of VS Code. If you want to be absolutely sure your extension has up-to-date flight information, you can do this. However, it probably isn't necessary.

So does that mean that we can just call isCachedFlightEnabled() here, and call isFlightEnabledAsync() for 1 time in the init method?

You shouldn't ever need to call isFlightEnabledAsync unless you want the absolute latest flight information. But I can't think of any scenarios where you would.

I see. Thank you Dayton Ellwanger (@daytonellwanger).

Another question, is below code needed in the init functions?

const asyncDummyCheck = (arg: any) => {
        expService?.isFlightEnabledAsync('dummy').then((v) => { return; }).catch((r) => { return; });
    };
    expService?.isCachedFlightEnabled('dummy').then(asyncDummyCheck).catch(asyncDummyCheck);
}

This should no longer be needed with the version of the vscode-tas-client package I mentioned above.

I see. Thank you for your help Dayton Ellwanger (@daytonellwanger). :)

I'll update the code according to the comments.

It might be better to read this from your package.json so you don't have to remember to update this when you change the extension version.

Are you OK paying the async cost here? Given that this could result in an http request, this could be 1-5 seconds.

You might be able to just do require('package.json')?

You should be able to drop these dummy checks

I tried to remove these lines. But I found that when I'm calling getExpService().isCachedFlightEnabled("defaultMaven");, the cached features are empty.

Within the dummy code, the cached features are correct.

// The vscode-tas-client I'm using is 0.0.659

Oh interesting. Maybe we still have another bug to track down. OK, keep these checks for now and I'll look into the issue ASAP, and with the next update to the package, you can remove them.

null check after getExpService?