Fix possible race condition that could lead to multiple didOpen's - #11120
Merged
Colen Garoutte-Carson (Colengms) merged 1 commit intoJun 23, 2023
Merged
Conversation
Sean McManus (sean-mcmanus)
approved these changes
Jun 22, 2023
Michelle Matias (michelleangela)
approved these changes
Jun 22, 2023
Colen Garoutte-Carson (Colengms)
deleted the
coleng/fix_processDelayedDidOpen_sync
branch
June 23, 2023 02:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed this while reviewing #11085 , and had the mistaken impression that use of
requestWhenReadywould have addressed this.Basically, the
hascheck followed by theaddis not 'thread'-safe if there is anawaitbetween those calls.Added a call to
takeOwnershipinstead of callingsendDidOpendirectly, to ensure any other contents oftakeOwnershipalso get called. (i.e.updateActiveDocumentTextOptions)