Fix second Rerun Last Task failing to launch for reevaluateOnRerun tasks#324571
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a tasks rerun regression in TerminalTaskSystem where consecutive invocations of “Rerun Last Task” for tasks with runOptions.reevaluateOnRerun: false could lose systemInfo, causing shell resolution to fall back to the local host (notably breaking in remote/WSL scenarios).
Changes:
- Preserve the previous
VerifiedTask.systemInfowhen re-executing a task via rerun, ensuring subsequent reruns continue to resolve the shell using the correct (remote) task system context.
Yoyokrazy
approved these changes
Jul 6, 2026
connor4312
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #175118. Regression from #132916 (dccb659), which made rerun re-resolve the shell instead of reusing the cached config. The re-resolve derives
platformfromresolver.taskSystemInfo, but_reexecuteCommandnever copiedsystemInfoonto the current task the way_executeCommanddoes — so after the first rerun the stored last task had an undefinedsystemInfo, and the next rerun resolved the shell on the local host (Path to shell executable '\usr\bin\zsh' does not exist). CarryingsystemInfoforward fixes it without reverting the original change.