Partial Mac OS Support - #98
Merged
Merged
Conversation
Member
|
Robert Onulak (@Ziugy) Bah, looks like my changes added conflicts. You'll have to merge develop into your branch or rebase. |
Member
Author
|
Josh Wittner (@jwittner) Resolved! |
Josh Wittner (jwittner)
requested changes
Apr 12, 2018
Josh Wittner (jwittner)
left a comment
Member
There was a problem hiding this comment.
Let's drop the 'setup' component like we discussed and clean up our platform testing.
… unsupported. Drops 'Setup' in favor of just stating 'Windows' on Windows platform. Updates README.md and -Examples to match with Setup changes.
Member
Author
|
Dropped |
Josh Wittner (jwittner)
approved these changes
Apr 16, 2018
Member
|
Tested on Windows and Linux and got expected results. Great work! Can't wait for full support. ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses issues with running on Mac OS - #41
Still to do: