Skip to content

Drop examples installer support - #63

Merged
Derek (derekfreed) merged 1 commit into
microsoft:developfrom
jwittner:fix/examplesInstaller
Mar 2, 2018
Merged

Drop examples installer support#63
Derek (derekfreed) merged 1 commit into
microsoft:developfrom
jwittner:fix/examplesInstaller

Conversation

@jwittner

@jwittner Josh Wittner (jwittner) commented Mar 2, 2018

Copy link
Copy Markdown
Member

The example project installer can be used to create an example project in any given directory. This was causing it to overwrite the real program directory with a Unity project. Just don't support it for now since it doesn't act like the other installers.

Fixes #60

@Ziugy Robert Onulak (Ziugy) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for me. You should create an enhancement issue for adding this back in in the future.

@derekfreed Derek (derekfreed) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange issue

@derekfreed
Derek (derekfreed) merged commit 45b666f into microsoft:develop Mar 2, 2018
@jwittner
Josh Wittner (jwittner) deleted the fix/examplesInstaller branch September 25, 2019 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants