Add default empty guid to fix an error on develop - #264
Add default empty guid to fix an error on develop#264Michael Smith (Exolun) wants to merge 2 commits into
Conversation
| [int]$SearchDepth = 3, | ||
| [Switch]$VerifyOnly, | ||
| [int]$PATLifetime = 7, | ||
| [guid]$AzureSubscription |
There was a problem hiding this comment.
Interesting - I tried this specifically before suggesting you convert to [guid]. Let me try some things.
There was a problem hiding this comment.
Confirmed - the issue is that you're assuming that $AzureSubscription is valid and then passing it into Update-PackageAuthConfig which ends up throwing the error. I have fixes for that an others about to go up.
Josh Wittner (jwittner)
left a comment
There was a problem hiding this comment.
Will follow up with a set of changes I have to fix this and other issues and we can discuss.
| [int]$SearchDepth = 3, | ||
| [Switch]$VerifyOnly, | ||
| [int]$PATLifetime = 7, | ||
| [guid]$AzureSubscription |
There was a problem hiding this comment.
Confirmed - the issue is that you're assuming that $AzureSubscription is valid and then passing it into Update-PackageAuthConfig which ends up throwing the error. I have fixes for that an others about to go up.
|
#265 addresses the problem with the guid as well as several others I found along the way. Would be nice to review in a call. |
|
Closing as this will be fixed by my PR. |
One of our users was testing on develop and seeing an error with no AzureSubscription provided, this is a fix so it won't error out.