Fix pipeline issues where System token should be used for the PAT if valid - #260
Merged
Michael Smith (Exolun) merged 1 commit intoJul 17, 2024
Conversation
…opposed to making a HTTP request
Josh Wittner (jwittner)
approved these changes
Jul 17, 2024
Josh Wittner (jwittner)
left a comment
Member
There was a problem hiding this comment.
Thanks for the improved handling of these dependencies!
Tushar Bhatnagar (tusharb86)
approved these changes
Jul 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been testing the new Cmdlet and discovered that we have scenarios where the agent machine is not authorized to generate a PAT via HTTP request, and there was some fallback code where we check if the SYSTEM_ACCESSTOKEN can be used as a valid pat and use that token in the .toml.
This pull request adds a conditional back in to check if this is the case for TF_BUILD environments.
Other minor changes: