Support override env var for gusi arg - #244
Merged
Josh Wittner (jwittner) merged 1 commit intoFeb 8, 2023
Merged
Conversation
| .PARAMETER BasePath | ||
| Under what base patterns should we look for Unity installs? | ||
| Defaults to Unity default locations by platform | ||
| Default can be configured by comma separated paths in $env:UNITY_SETUP_INSTANCE_DEFAULT_BASEPATH |
There was a problem hiding this comment.
This is kind of confusing since we refer to this as a "pattern" as well as a "path".
Member
Author
There was a problem hiding this comment.
I agree, think the arg should be 'Pattern', but don't want to break the api. Out of scope of this change I think too.
Steven Liss (mister-liss)
approved these changes
Feb 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for overriding the default value of
BasePathinGet-UnitySetupInstance. Setting$env:UNITY_SETUP_INSTANCE_BASEPATH_DEFAULTto a comma separated list will default the search paths to the elements of that list.