Add unity accelerator parameters - #235
Merged
Merged
Conversation
|
|
Comment on lines
+1765
to
+1772
| [parameter(Mandatory = $false)] | ||
| [string]$CacheServerEndpoint, | ||
| [parameter(Mandatory = $false)] | ||
| [string]$CacheServerNamespacePrefix, | ||
| [parameter(Mandatory = $false)] | ||
| [switch]$CacheServerDisableDownload, | ||
| [parameter(Mandatory = $false)] | ||
| [switch]$CacheServerDisableUpload |
Member
There was a problem hiding this comment.
Can you add a description of these parameters in the function header comment? perhaps even example?
There was a problem hiding this comment.
An example in the readme would be great!
There was a problem hiding this comment.
Thanks for the suggestions, I agree it's much clearer now with the examples.
Derek (derekfreed)
approved these changes
Jun 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The unity cmd tools allow configure the Unity Accelerator as specified here
I'm just exposing those parameters and passing them down to Unity's cmd.
There are 2 flags,
CacheServerDisableUploadandCacheServerDisableDownloadthat can be specified if we want to disable specific behaviours. So the default would be true, to reduce clutter.