Performance enhancements for Get-UnitySetupInstance - #228
Merged
Josh Wittner (jwittner) merged 1 commit intoJul 7, 2021
Merged
Conversation
Josh Wittner (jwittner)
requested review from
Robert Onulak (Ziugy) and
Derek (derekfreed)
July 6, 2021 21:27
Derek (derekfreed)
approved these changes
Jul 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This improves search speed ~33% generally for newer versions of unity by actually stopping the pipeline after finding the first version match in header files.
It improves search speed ~95% for newer versions of Unity on Windows where a known header file is checked here first before doing a general scan.
If anyone with a Mac can help me determine what header file to search to discover the version on Mac/Linux I'd be more than keen to add it for a first pass check.