Add new cmdlet to test/report on meta file integrity - #197
Merged
Josh Wittner (jwittner) merged 3 commits intoFeb 24, 2020
Merged
Conversation
Member
Author
|
Seeing errors converting the meta file for dlls - due to duplicate keys. Gonna try a work around. |
Member
Author
This is fixed in latest, also now have progress reporting. =) |
Derek (derekfreed)
approved these changes
Feb 24, 2020
Derek (derekfreed)
left a comment
Member
There was a problem hiding this comment.
The only thing I found is that there is an unhandled case where filenames with [brackets] do not have their content found with get-content so the test results in metafiles with no associated content. This thought is a limitation of powershell 5 and below. This could be fixed in powershell 6 by using get-content -literalpath. In powershell 5 and below literlpath doe snot work with -exclude -include
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Definitely open to arguments for a shorter name on this cmdlet. =)