Support local installs of 2019.2, formatting fixes. - #193
Merged
Josh Wittner (jwittner) merged 3 commits intoSep 26, 2019
Conversation
Forrest Trepte (ForrestTrepte)
approved these changes
Sep 26, 2019
Forrest Trepte (ForrestTrepte)
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me. Tested with Unity 2019.2.6f1, but with my installed components it already worked before this change (Windows, Windows_IL2CPP, UWP_IL2CPP).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main functional change is in the first commit, or check UnitySetup.psm1 ~ Line 1200.
I'm now searching as a last resort through any .h files with UNITY_VERSION defined.
Fixes #192