Fixes 2019.1 Unity Instance Searching - #171
Conversation
…validate the version that way.
There was a problem hiding this comment.
Thanks for the contribution Stephen Hodgson (@StephenHodgson) - would love to get this issue resolved! =)
UnitySetup originally used your proposed method for version discovery, but ultimately I found that it was hurting adoption because people have Unity installed in all kinds of weird folders and it was restrictive to only include versions installed by UnitySetup (or randomly installed in a matching pattern). If this ivy is gone, I'd like to find (hopefully) a part of the install that is always under Unity's control for determining the version. If we find another ivy (iirc, there were several), we can check for both.
I'm wondering if you scoured around and didn't find anything already?
|
I was not able to find anything similar. I looked quite a bit to make sure. Yeah looking back I didn't account for strange folder names and custom install locations for this. |
|
But gotta have this fixed asap. |
|
Josh Wittner (@jwittner) what if we do a recursive search for any ivy files? Then if that fails get the new |
… a fallback for unity version
|
Josh Wittner (@jwittner) I think you'll really like the new version :) |
|
I just noticed we should also update |
Josh Wittner (jwittner)
left a comment
There was a problem hiding this comment.
Thanks for another great contribution Stephen Hodgson (@StephenHodgson) ! Hit errors trying to import, but did an eyeball review as well.
|
Josh Wittner (@jwittner) This is ready for re-review. I pretty much just match the search paths to a version the use that as my path for the instance. I also updated the version matching in the setup instance constructor as well If you want to squash and merge this PR I'm cool with that so all these commits don't pollute the history. |
|
Stephen Hodgson (@StephenHodgson) I was still seeing issues, but I've updated and pushed changes that fix them for me. I now get handy warnings for my busted old half uninstalled unity folders. =) Please review and test again, if it's working for you, I'll go ahead and merge it in. =) |
|
Josh Wittner (@jwittner) works on my end! |
|
Josh Wittner (@jwittner) anything else for me to do on my end? |
|
Josh Wittner (@jwittner) Please re-review :) |
|
Robert Onulak (@Ziugy) could you also take a look see please? |
Updated the
UnitySetupInstanceto search for themodules.jsonthen falls back to recursively looking forivy.xmlFixes: