fix(webSocketRoute): allow no trailing slash in route matching#2687
Merged
mxschmitt merged 2 commits intomicrosoft:mainfrom Dec 12, 2024
Merged
Conversation
mxschmitt
commented
Dec 12, 2024
| match = urljoin(base_url, match) | ||
| parsed = urlparse(match) | ||
| if parsed.path == "": | ||
| parsed = parsed._replace(path="/") |
Contributor
Author
There was a problem hiding this comment.
_replace seems to be the recommendation as per here.
yury-s
approved these changes
Dec 12, 2024
Member
yury-s
left a comment
There was a problem hiding this comment.
Why does it work in Node.js and other ports?
Contributor
Author
In Node.js we do the same here: https://github.com/microsoft/playwright/blob/16a1552e7490139f295086ab52cc0d7b3901eaac/packages/playwright-core/src/utils/isomorphic/urlMatch.ts#L128 The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2686