fix: guard against missing oMath element in DOCX math converter (#1979)#1995
Open
hanhan761 wants to merge 1 commit into
Open
fix: guard against missing oMath element in DOCX math converter (#1979)#1995hanhan761 wants to merge 1 commit into
hanhan761 wants to merge 1 commit into
Conversation
…osoft#1979) Add a None check in _convert_omath_to_latex() to return an empty string when the math element is missing, instead of passing None to oMath2Latex() which raises TypeError. Fixes microsoft#1979
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a DOCX file contains a malformed math equation where the \oMath\ child element is missing, _convert_omath_to_latex()\ passes \None\ to \oMath2Latex(), which raises \TypeError\ because \None\ is not iterable.
This change adds a \None\ check after \math_root.find()\ and returns an empty string as a fallback, allowing the conversion to continue without crashing.
Issue
Fixes #1979
Verification